Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prints the constraints errors on CI #5444

Merged
merged 1 commit into from
May 16, 2023
Merged

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented May 16, 2023

What's the problem this PR addresses?

When a constraints fail, we currently print a message suggesting to run yarn constraints to get the full details. However, this doesn't make sense on CI, where the command can't be run.

How did you fix it?

On CI, we now print the error list.

I'm however kinda reconsidering this approach of "run yarn constraints for more details" - if this message is displayed, the user will have to run the command 100% of the time. By this point, why not display the output by default? 🤔

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit eaffd15 into master May 16, 2023
@arcanis arcanis deleted the mael/ci-constraints-check-result branch May 16, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant