Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocorrects git:// into https:// for GitHub #5440

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

arcanis
Copy link
Member

@arcanis arcanis commented May 15, 2023

What's the problem this PR addresses?

GitHub doesn't support git:// anymore (and hasn't been for some time now):
https://github.blog/changelog/2022-03-15-removed-unencrypted-git-protocol-and-certain-ssh-keys/

A couple of old dependencies (including internal ones) still reference git:// urls, which prevents them from being used.

How did you fix it?

Just autofix the git://github.com url into https://github.com. I don't think this has any negative impact.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 3234743 into master May 16, 2023
@arcanis arcanis deleted the mael/git-default-github branch May 16, 2023 10:03
merceyz pushed a commit that referenced this pull request May 16, 2023
* Autocorrects git:// into https://

* Updates the url
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant