Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnp): disable patching binding.fstat when possible #5402

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Apr 22, 2023

What's the problem this PR addresses?

With nodejs/node#45659 Node.js started lazy loading their internal translators so we can disable our patching of binding.fstat since it's using the patched readFileSync.

How did you fix it?

Disabled the patching of binding.fstat in Node.js versions with lazy loading.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit f253613 into master Apr 24, 2023
@arcanis arcanis deleted the merceyz/fix/pnp-fs-binding branch April 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants