perf(core): setup workspaces in parallel #5367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Yarn loads workspaces one at a time which when you get to 1000s of workspaces noticeably slows down the project setup.
How did you fix it?
Changed the loading from a breadth-first one at a time to a depth-first multiple at a time load
Results
When I implemented and tested this on the Next.js repo with all examples included (291 workspaces) back in 2020-12-04 it didn't have much of an impact
however this improvement scales so on the DefinitelyTyped repo with its 8629 workspaces (matching only
types/*
) it's more noticeable.Checklist