fix(pnp): esm - use correct error code when module not found #5355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
requested changes
Mar 29, 2023
There was a problem hiding this comment.
Thanks for the fix!
Could you add a test to https://github.com/yarnpkg/berry/blob/ca475757fe85cdc2c4b4441f6d65d38fdab230ad/packages/acceptance-tests/pkg-tests-specs/sources/pnp-esm.test.ts?
|
Added tests |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
merceyz
previously approved these changes
Apr 3, 2023
merceyz
requested changes
Apr 24, 2023
merceyz
approved these changes
Apr 24, 2023
merceyz
changed the title
merceyz
added a commit
that referenced
this pull request
Apr 24, 2023
* fix(pnp): Use correct error code when module not found * test(pnp): Add tests * Commits file updates * fix(pnp): re-throw regardless of what the error is --------- Co-authored-by: Kristoffer K <merceyz@users.noreply.github.com> Co-authored-by: Maël Nison <nison.mael@gmail.com>
merceyz
added a commit
that referenced
this pull request
Apr 24, 2023
* fix(pnp): Use correct error code when module not found * test(pnp): Add tests * Commits file updates * fix(pnp): re-throw regardless of what the error is --------- Co-Authored-By: Kristoffer K <merceyz@users.noreply.github.com> Co-Authored-By: Maël Nison <nison.mael@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR makes the PnP ESM loader throw with error code
ERR_MODULE_NOT_FOUND(instead ofMODULE_NOT_FOUND) when a request cannot be resolved.Closes #5334
How did you fix it?
The error is thrown by the PnP CJS hook, and the ESM loader just calls the CJS hook. So we can just catch the error in the ESM loader, change the error code, and rethrow.
I am not sure about the package releases. I have marked
pnp,plugin-pnpandclias patch releases since other packages doesn't seem to use the ESM loader.Checklist