Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use stream.pipeline #5283

Merged
merged 1 commit into from
Feb 21, 2023
Merged

test: use stream.pipeline #5283

merged 1 commit into from
Feb 21, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Feb 19, 2023

What's the problem this PR addresses?

Simplification of our use of Node.js streams.

How did you fix it?

Use stream.pipeline to pipe data between streams.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

RDIL
RDIL approved these changes Feb 21, 2023
View reviewed changes
Copy link
Member

@RDIL RDIL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better!

@merceyz merceyz merged commit 0ea04e9 into master Feb 21, 2023
@merceyz merceyz deleted the merceyz/test/pipeline branch February 21, 2023 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDIL RDIL RDIL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@merceyz @RDIL