Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdks): add @astrojs/language-server to vscode sdks #5223

Merged
merged 2 commits into from
Jan 26, 2023
Merged

feat(sdks): add @astrojs/language-server to vscode sdks #5223

merged 2 commits into from
Jan 26, 2023

Conversation

ezracelli
Copy link
Contributor

What's the problem this PR addresses?

astro-vscode has an ls-path setting that behaves the same as svelte-vscode's. However, there is currently no SDK generation available in @yarnpkg/sdks to generate a compatible file.

How did you fix it?

Added generators for @astrojs/language-server to @yarnpkg/sdks in the same manner as svelte-language-server (#1465).

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit a1bad9e into yarnpkg:master Jan 26, 2023
@ezracelli ezracelli deleted the feat/sdks/astro branch January 26, 2023 21:07
merceyz pushed a commit that referenced this pull request Jan 29, 2023
* feat(sdks): add `@astrojs/language-server` to vscode sdks

* docs(editor-sdks): add `@astrojs/language-server` to support tools list
@altsalt
Copy link

altsalt commented Mar 25, 2024

Sorry for necro'ing an old PR, but was wondering whether there is a reason you pinned this to @astrojs/language-server rather than also enabling it when astro is found in the package.json?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants