Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compat): update patch for typescript@5.0.0-beta #5210

Merged
merged 2 commits into from
Jan 29, 2023

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jan 21, 2023

What's the problem this PR addresses?

The PnP compatibility patch for TypeScript doesn't apply to typescript@5.0.0-beta.

Includes merceyz/TypeScript#1 in >=4.8.1-rc (cc @stephank)
Fixes #4050 in >=4.8.1-rc

How did you fix it?

Reworked the microsoft/TypeScript#35206 patch for the 5.0.0-beta release.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title fix(compat): update patch for typescript@5.0.1-beta fix(compat): update patch for typescript@5.0.0-beta Jan 27, 2023
@merceyz merceyz marked this pull request as ready for review January 27, 2023 09:31
@HairyRabbit
Copy link

any update?

@arcanis arcanis merged commit d5428d2 into master Jan 29, 2023
@arcanis arcanis deleted the merceyz/fix/typescript-50 branch January 29, 2023 06:55
merceyz added a commit that referenced this pull request Jan 29, 2023
* fix(compat): update patch for `typescript@5.0.1-beta`

* deps: update typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The Typescript PR needs to be more robust in getPnpApi to work with Vite/esbuild/rollup in the browser.
3 participants