Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove obsolete forced unplug entries #5181

Merged
merged 4 commits into from
Jan 8, 2023

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

This PR removes some entries from FORCED_UNPLUG_PACKAGES that are no longer needed:

  • nan - already unplugged because of .h files
  • node-gyp - already unplugged because of .cc files
  • node-addon-api - already unplugged because of .h and .c files
  • fsevents - already unplugged because of .node files and conditions
  • node-pre-gyp doesn't need to be unplugged because nobody remembers the reason it was originally unplugged anymore and it doesn't currently include any code that would require it to be. The package has also been deprecated and renamed to @mapbox/node-pre-gyp which isn't on our list (and therefore isn't unplugged) and nobody has complained about it not working anymore. I've also done a quick check and both seem to work without unplugging.

How did you fix it?

Removed them.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz
Copy link
Member

merceyz commented Jan 8, 2023

I pushed a commit to trigger all the e2e tests just to be on the safe side regarding node-pre-gyp.

Edit: Test complete, Gatsby and Gulp failed due to #5177, Storybook hasn't worked for a long time, the rest was fine.

refactor:

One could argue it's a perf: since it's one less package to unplug.

@paul-soporan paul-soporan changed the title refactor: remove obsolete forced unplug entries perf: remove obsolete forced unplug entries Jan 8, 2023
@paul-soporan paul-soporan merged commit ce03d0d into master Jan 8, 2023
@paul-soporan paul-soporan deleted the paul/refactor/remove-obsolete-forced-unplug branch January 8, 2023 02:32
merceyz added a commit that referenced this pull request Jan 29, 2023
Co-authored-by: merceyz <merceyz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants