perf: remove obsolete forced unplug entries #5181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This PR removes some entries from
FORCED_UNPLUG_PACKAGES
that are no longer needed:nan
- already unplugged because of.h
filesnode-gyp
- already unplugged because of.cc
filesnode-addon-api
- already unplugged because of.h
and.c
filesfsevents
- already unplugged because of.node
files and conditionsnode-pre-gyp
doesn't need to be unplugged because nobody remembers the reason it was originally unplugged anymore and it doesn't currently include any code that would require it to be. The package has also been deprecated and renamed to@mapbox/node-pre-gyp
which isn't on our list (and therefore isn't unplugged) and nobody has complained about it not working anymore. I've also done a quick check and both seem to work without unplugging.How did you fix it?
Removed them.
Checklist