ci: update to Node.js v18 #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The failing e2e tests (Storybook and Angular) are unrelated to this change. |
merceyz
added a commit
that referenced
this pull request
Apr 24, 2023
* ci: update to Node.js v18 * ci: simplify preact test * ci: use Node.js v16 for preact
3 tasks
arcanis
pushed a commit
that referenced
this pull request
Jan 15, 2024
**What's the problem this PR addresses?** The angular PnP test started failing with #5051. **How did you fix it?** Lock the Angular PnP test to Node.js v20 for now. **Checklist** - [x] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). - [x] I have set the packages that need to be released for my changes to be effective. - [x] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Node.js v18 is LTS now so we should run our e2e tests against it.
https://nodejs.org/en/blog/release/v18.12.0/
Also fixes:
How did you fix it?
Updated the CI to Node.js v18.
Checklist