perf(pack): remove duplicated assignment of browser in publishConfig
#5004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
browser in publishConfigbrowser in publishConfig
merceyz
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Thanks for the PR, good catch!
Looks like it was accidentally added in https://github.com/yarnpkg/berry/pull/1574/files#diff-2672ab4fd527bc6d23c648c67219ea1e7f29e57db502f973d0197a44f896e950
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The
browserfield is assigned twice while packing (first assignment, second assignment). I removed the unnecessary second assignment....
How did you fix it?
...
Checklist