Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(compat): avoid rebuilding patches when changing the range #5001

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Oct 29, 2022

What's the problem this PR addresses?

Whenever the range for a PnP compatibility patch for TypeScript is changed the patch is rebuilt which is unnecessary since the content itself wont change, only the range.

How did you fix it?

Update the range in the existing patch instead of rebuilding it.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit b251d55 into master Nov 1, 2022
@arcanis arcanis deleted the merceyz/build/compat-patches branch November 1, 2022 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants