fix(suggestUtils): use workspace.anchoredLocator
#4937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It probably would make even more sense to use |
|
We already do that for selected descriptors (for |
|
(restarting the tests, which didn't trigger due to a GH incident) |
merceyz
pushed a commit
that referenced
this pull request
Nov 3, 2022
3 tasks
arcanis
pushed a commit
that referenced
this pull request
Jul 28, 2023
**What's the problem this PR addresses?** <!-- Describe the rationale of your PR. --> <!-- Link all issues that it closes. (Closes/Resolves #xxxx.) --> `workspace.locator` is quite useless and only creates confusion with `workspace.anchoredLocator`. At the moment, it's only used in places that need an ident, which `workspace.anchoredLocator` can happily provide. In the past, it was also used accidentally instead of `workspace.anchoredLocator` before I fixed it in #4937. **How did you fix it?** <!-- A detailed description of your implementation. --> Removed it since it doesn't provide any benefits. Its only actual use is comparisons in `project.tryWorkspaceByLocator`, but nobody has ever passed it to `project.tryWorkspaceByLocator` anyways. **Checklist** <!--- Don't worry if you miss something, chores are automatically tested. --> <!--- This checklist exists to help you remember doing the chores when you submit a PR. --> <!--- Put an `x` in all the boxes that apply. --> - [X] I have read the [Contributing Guide](https://yarnpkg.com/advanced/contributing). <!-- See https://yarnpkg.com/advanced/contributing#preparing-your-pr-to-be-released for more details. --> <!-- Check with `yarn version check` and fix with `yarn version check -i` --> - [X] I have set the packages that need to be released for my changes to be effective. <!-- The "Testing chores" workflow validates that your PR follows our guidelines. --> <!-- If it doesn't pass, click on it to see details as to what your PR might be missing. --> - [X] I will check that all automated PR checks pass before the PR gets reviewed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
findProjectDescriptorsreturns a list ofworkspace.locators, which is then compared againstworkspace.anchoredLocator, when they can never be equal.How did you fix it?
Made it return a list of
workspace.anchoredLocators since in the future I'd prefer to just completely get rid ofworkspace.locatoranyways and it also makes more sense to display theanchoredLocatorin the interactive prompt since it matters more that the package is a workspace, not that it has a specific version.Checklist