Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update some dependency to reduce peer dependency warning #4935

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

jj811208
Copy link
Contributor

@jj811208 jj811208 commented Oct 5, 2022

What's the problem this PR addresses?

Following the advice of #418,

I found two warnings from yarn itself

➤ YN0060: │ @yarnpkg/monorepo@workspace:. provides eslint (pf82c3) with version 8.2.0, which doesn't satisfy what @yarnpkg/eslint-config and some of its descendants request
➤ YN0002: │ acceptance-tests@workspace:packages/acceptance-tests doesn't provide jest (pcc8ab), requested by jest-json

...

How did you fix it?

packages/acceptance-tests

  • add jest@^28.1.3 to devDependencies

packages/eslint-config

  • upgrade eslint-plugin-react from ^7.25.1 to ^7.31.8

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@jj811208 jj811208 force-pushed the fix/peer-dependency-warnings branch from 45e1520 to 2d53199 Compare October 5, 2022 06:41
@arcanis arcanis merged commit 5132b22 into yarnpkg:master Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants