Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix the typescript e2e test #4888

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

jj811208
Copy link
Contributor

@jj811208 jj811208 commented Sep 22, 2022

What's the problem this PR addresses?

Related #4853

I've noticed these days that master branch CI always has errors. (github action log)

...

How did you fix it?

After checking, I found some small things that we have missed

  1. Update the path to libzip in scripts/test-typescript-patch.js
  2. Add @yarnpkg/libzip to @yarnpkg/monorepo devDependencies
  3. Run yarn node ./scripts/test-typescript-patch.js to confirm that it has been fixed

...

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz changed the title fix: Fix CI errors in master branch ci: fix the typescript e2e test Sep 22, 2022
@merceyz merceyz merged commit da70ece into yarnpkg:master Sep 22, 2022
@merceyz
Copy link
Member

merceyz commented Sep 22, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants