refactor(MessageName): deprecate CROSS_DRIVE_VIRTUAL_LOCAL
#4859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RDIL
approved these changes
Sep 17, 2022
arcanis
deleted the
paul/refactor/deprecate-CROSS_DRIVE_VIRTUAL_LOCAL
branch
merceyz
pushed a commit
that referenced
this pull request
Oct 22, 2023
(cherry picked from commit 2931e4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Same as #4703.
CROSS_DRIVE_VIRTUAL_LOCALhas been unused ever since theVirtualFSwas introduced.How did you fix it?
Deprecated it so that it shows up as deprecated in editors. This is the most we can do since we can never remove
MessageNames.I also linked a comment in the PR that introduced it for context.
Checklist