feat: Moves the bulk of ZipOpenFS into a new MountFS #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The logic allowing to "mount" virtual entities on the disk isn't trivial (finding the mount point and branching the code, handling file descriptors, managing the cache, etc). We implemented it in ZipOpenFS, making it difficult to implement different mount logics without duplicating a lot of tedious work.
How did you fix it?
Most of the ZipOpenFS logic was moved to a new MountFS class. The options unique to zip (
readOnlyArchive,libzip, etc) are handled in a subclass from MountFS, which tweaks the parameters before forwarding them.Checklist