fix(essentials): yarn add --peer and --dev do not work when used together
#4800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flat arrays easy
…to prevent confusion
jj811208
changed the title
--peer, --dev not working--peer and --dev do not work when used together
jj811208
force-pushed
the
fix-yarn-add-command
branch
from
c303386
to
721735e
Compare
merceyz
requested changes
Aug 27, 2022
There was a problem hiding this comment.
Thanks for the PR, please add some tests to https://github.com/yarnpkg/berry/blob/15c481dce19f1a7e56b875b96f11c9ef67dc4c2d/packages/acceptance-tests/pkg-tests-specs/sources/commands/add.test.ts to verify that the new behaviour works and to prevent regression.
jj811208
force-pushed
the
fix-yarn-add-command
branch
from
721735e
to
de54cb6
Compare
Thanks for the quick review! I added a new test to this commit de54cb6 . |
|
Thanks! |
merceyz
pushed a commit
that referenced
this pull request
Sep 28, 2022
…together (#4800) * refactor(essentials): replace tuple arrays with object arrays, making flat arrays easy * refactor(essentials): rename `suggestions` to `suggestedDescriptors` to prevent confusion * fix(essentials): yarn add `--peer`, `--dev` not working at the same time * test: add test for `yarn add --dev --peer` usage
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Yarn add
--peerand--devdo not work when used togetherResolves #4691
...
How did you fix it?
Let the return value of the
suggestTargetfunction of thepackages/plugin-essentials/sources/commands/add.tsfile change fromsuggestUtils.TargettosuggestUtils.Target[], It is possible to add different types of dependencies at once...
Checklist