Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unplugged folder when switching to a different linker #4772

Merged
merged 1 commit into from
Aug 18, 2022
Merged

fix: remove unplugged folder when switching to a different linker #4772

merged 1 commit into from
Aug 18, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

The PnpLinker doesn't remove the unplugged folder when switching to a different linker.

How did you fix it?

Made it remove it and added tests.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit bb136ed into master Aug 18, 2022
@arcanis arcanis deleted the paul/fix/pnp-linker-remove-unplugged branch August 18, 2022 09:30
merceyz pushed a commit that referenced this pull request Dec 12, 2022
@paul-soporan @merceyz
fix: remove unplugged folder when switching to a different linker (#4772
aaf7ef3 
)
@legobeat legobeat mentioned this pull request Jul 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paul-soporan @arcanis