Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): remove dead code in setupWorkspaces #4771

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

paul-soporan
Copy link
Member

What's the problem this PR addresses?

setupWorkspaces tries to populate workspace.dependencies using the corresponding package from storedPackages, which isn't populated until a resolution / restoreInstallState pass is run, so the code is completely useless.

How did you fix it?

Removed the code since it serves no purpose and the field is populated later anyways.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@paul-soporan paul-soporan changed the title refactor(core): remove dead code in setupWorkspaces perf(core): remove dead code in setupWorkspaces Aug 17, 2022
@arcanis arcanis merged commit f0e2107 into master Aug 18, 2022
@arcanis arcanis deleted the paul/refactor/remove-dead-code branch August 18, 2022 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants