test: clear timeout after test finishes #4715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
requested changes
Aug 7, 2022
packages/acceptance-tests/pkg-tests-core/sources/utils/tests.ts
Outdated
Show resolved
Hide resolved
edvardchen
force-pushed
the
fix-test-hanging
branch
from
c44ba90
to
6ed62b0
Compare
merceyz
requested changes
Aug 7, 2022
packages/acceptance-tests/pkg-tests-core/sources/utils/tests.ts
Outdated
Show resolved
Hide resolved
packages/acceptance-tests/pkg-tests-core/sources/utils/tests.ts
Outdated
Show resolved
Hide resolved
Co-Authored-By: Kristoffer K. <merceyz@users.noreply.github.com>
merceyz
force-pushed
the
fix-test-hanging
branch
from
9e6dd2b
to
a29ae1d
Compare
merceyz
changed the title
merceyz
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
fix that test:integration cannot exit gracefully, for example, https://ci.nodejs.org/job/citgm-smoker-nobuild/1353/nodes=win10-vs2019/console
How did you fix it?
unref the timer
Checklist