Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove workaround for Angular PnP e2e test #4614

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Jul 8, 2022

What's the problem this PR addresses?

The bug has been fixed upstream in angular/angular-cli#23487 and ng-packagr/ng-packagr#2367 so we can remove the workaround.

How did you fix it?

Removed it.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz requested a review from arcanis as a code owner July 8, 2022 17:43
@arcanis arcanis merged commit 39f5cbe into master Jul 12, 2022
@arcanis arcanis deleted the merceyz/ci/angular-workaround branch July 12, 2022 14:05
merceyz added a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants