fix(plugin-patch): avoid creating rename diffs

[redabacha]

What's the problem this PR addresses?

helps to avoid #3341 by generating diffs without renames

How did you fix it?

passed --no-renames option when calling git diff

Checklist

• I have read the Contributing Guide.

• I have set the packages that need to be released for my changes to be effective.

• I will check that all automated PR checks pass before the PR gets reviewed.

[arcanis]

Shouldn't we rather implement rename in ZipFS using zip_file_rename? Otherwise the produced patches will be very large (especially if the renamed file is a bundle or something like this).

[redabacha]

hi @arcanis, yes agreed this is more of a simple stopgap solution until someone smarter than me or when i have more time maybe can implement the libzip file rename. i do personally think it's a better dx to have the patch apply successfully rather than receive a very ambiguous error message despite the larger diff 😅.

[arcanis]

Fair enough! 🙂

[paul-soporan]

Shouldn't we rather implement rename in ZipFS using zip_file_rename?

I've tried to do it multiple times but for some reason I can't seem to make it work because zip_file_rename always returns an error code early and I can't figure out why.