Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use monospace for fallback font of PT Mono #4495

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

rinsuki
Copy link
Contributor

@rinsuki rinsuki commented May 26, 2022

What's the problem this PR addresses?

some styles are missing fallback font for PT Mono.

so it would be serif if web fonts aren't avilable...

image

How did you fix it?

I just add monospace as fallback font to some styles that missing fallback font.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

some styles are using monospace for fallback, but some styles are missing fallback.
@rinsuki rinsuki marked this pull request as ready for review May 26, 2022 05:10
@arcanis arcanis merged commit 4883b3a into yarnpkg:master Jun 1, 2022
merceyz pushed a commit that referenced this pull request Jul 13, 2022
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Sep 21, 2022
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Oct 5, 2022
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Nov 16, 2022
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Dec 20, 2022
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Feb 1, 2023
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Mar 16, 2023
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request May 1, 2023
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Jun 1, 2023
some styles are using monospace for fallback, but some styles are missing fallback.
merceyz pushed a commit that referenced this pull request Oct 21, 2023
some styles are using monospace for fallback, but some styles are missing fallback.

(cherry picked from commit 4883b3a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants