chore(extensions): add tabbable dependency to focus-trap-react
#4492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
changed the title
tabbable dependency to focus-trap-react
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
focus-trap-react directly depends on tabbable, but relies on obtaining it transitively via its dependency on focus-trap. PR to resolve upstream here: focus-trap/focus-trap-react#691
...
How did you fix it?
Added a new package extension for focus-trap-react.
Note: I'm almost certain that I didn't apply the staged version changes correctly. I'm not sure exactly how the yarnpkg/extensions package is used, so I'm not totally sure how upgrading it should affect other packages! Happy to make any changes necessary to the version file.Thanks @merceyz!...
Checklist