Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdks): update for VSCode 1.68 #4485

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented May 24, 2022

What's the problem this PR addresses?

VSCode 1.68 changed the format for in-memory file paths in microsoft/vscode#148940 and microsoft/vscode#149125.

VSCode 1.68 isn't released yet so this is only noticeable in VSCode Insiders and since the version detection doesn't work with the Remote Development extensions I'll leave this as a draft until it has been released.

How did you fix it?

Updated the paths to match the new format.

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz merceyz force-pushed the merceyz/fix/sdk-vscode-1-68 branch from c0f2871 to e221ad7 Compare June 10, 2022 08:53
@merceyz merceyz marked this pull request as ready for review June 10, 2022 08:53
@arcanis arcanis enabled auto-merge (squash) June 10, 2022 09:11
@arcanis arcanis merged commit beefef7 into master Jun 10, 2022
@arcanis arcanis deleted the merceyz/fix/sdk-vscode-1-68 branch June 10, 2022 09:31
merceyz added a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants