Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cygpath for MINGW (Git Bash) #4409

Merged
merged 1 commit into from
May 3, 2022
Merged

Use cygpath for MINGW (Git Bash) #4409

merged 1 commit into from
May 3, 2022

Conversation

dahlbyk
Copy link
Contributor

@dahlbyk dahlbyk commented Apr 28, 2022

What's the problem this PR addresses?

yarnpkg/yarn#5349

Edit @merceyz :
Doesn't address yarnpkg/yarn#5349 as this repo isn't used for the classic shell script.

How did you fix it?

Also use cygpath for MINGW, similar to https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/scripts/build-dist.sh#L8-L10.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@merceyz
Copy link
Member

merceyz commented Apr 28, 2022

That file isn't in use by the Yarn classic binary unless you manually grab it from this repo.

@dahlbyk
Copy link
Contributor Author

dahlbyk commented Apr 28, 2022

That file isn't in use by the Yarn classic binary unless you manually grab it from this repo.

Trying to reconcile this with yarnpkg/yarn#5349 (comment).

@arcanis
Copy link
Member

arcanis commented May 3, 2022

The change looks reasonable so I'm fine with merging it, however as @merceyz mentioned it doesn't have impact on the problem itself, which I think comes from https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/bin/yarn.

@arcanis arcanis merged commit d7d260e into yarnpkg:master May 3, 2022
@dahlbyk
Copy link
Contributor Author

dahlbyk commented May 8, 2022

The change looks reasonable so I'm fine with merging it, however as @merceyz mentioned it doesn't have impact on the problem itself, which I think comes from https://github.com/yarnpkg/yarn/blob/3119382885ea373d3c13d6a846de743eca8c914b/bin/yarn.

I submitted here based on Contributing to yarnpkg/yarn. If a similar patch would be accepted for 1.x, I am glad to submit there.

merceyz pushed a commit that referenced this pull request Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants