fix(essentials): different error when importing built-in plugins #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
commented
Apr 26, 2022
Comment on lines
+26
to
+35
|
|
||
| test( | ||
| `it should detect attempts to import built-in plugins`, | ||
| makeTemporaryEnv({}, async ({path, run, source}) => { | ||
| await expect(run(`plugin`, `import`, `workspace-tools`)).rejects.toMatchObject({ | ||
| code: 1, | ||
| stdout: expect.stringContaining(`is already installed`), | ||
| }); | ||
| }), | ||
| ); |
There was a problem hiding this comment.
This test will only work once this PR is merged due to the URL it fetches the range from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
yarn import plugin <built-in>shows an unhelpful error.yarn set version from sourcesfrom 3 to 4 #4331 doesn't match the canary releasesCloses #4396
How did you fix it?
Checklist