Fixes the Parcel E2E test #4400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Apr 26, 2022
Comment on lines
+407
to
+415
| // If turning 1.0.0 into ^1.0.0 would cause it to resolve to something else | ||
| // (for example 1.1.0), then we don't add the modifier. | ||
| // | ||
| // This is to account for "weird" release strategies where things like | ||
| // prereleases are released as older versions than the latest available | ||
| // ones. | ||
| // | ||
| // Ex 1: https://github.com/parcel-bundler/parcel/issues/8010 | ||
| // Ex 2: https://github.com/sveltejs/kit/discussions/4645 |
There was a problem hiding this comment.
We could probably revert #4395 with this change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
See parcel-bundler/parcel#7999
How did you fix it?
Adding
@parcel/coreto the dependencies. This way users can add it to their dep and unblock the parcelrc issue. However perhaps this should be added to the Parcel documentation?Checklist