feat(libzip): add function types #4318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
force-pushed
the
merceyz/feat/emscripten-types
branch
from
7cdbea8
to
e51d32e
Compare
github-actions
bot
removed
the
infra: pending update
merceyz
added a commit
that referenced
this pull request
Feb 2, 2023
* feat(libzip): add function types * chore: update artefact Co-authored-by: Yarn Bot <nison.mael+yarnbot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
@yarnpkg/libzipdoesn't have good types for the functions it exports.How did you fix it?
Update
@types/emscriptento benefit from DefinitelyTyped/DefinitelyTyped#57163 and fix the errors it highlighted.Checklist