fix(pack): handle excluding from included parent directory #4317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivikr
reviewed
Apr 4, 2022
| } | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| } | ||
|
|
||
| function isMatch(path: string, patterns: Array<string>) { | ||
| function matchPatternType(path: string, patterns: Array<string>) { |
There was a problem hiding this comment.
nite: rename to getMatchPatternType (similar to other functions which have verb prior to action, like isMatch or isMatchBasename or isIgnore)?
Suggested change
| function matchPatternType(path: string, patterns: Array<string>) { | |
| function getMatchPatternType(path: string, patterns: Array<string>) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Using the
filesfield inpackage.jsonto include a directory but exclude files in said directory doesn't work.How did you fix it?
Differentiate between "no match" and "negated match" in the
isIgnoredcheck.Checklist