Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-pnp): wait for unplugging to finish before finalizing #4278

Merged
merged 1 commit into from
Mar 29, 2022

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Mar 26, 2022

What's the problem this PR addresses?

There is a race condition in the PnP linker where it can end up trying to read the unplugged folder before it is created.

Fixes https://github.com/yarnpkg/berry/runs/5705475812?check_suite_focus=true#step:5:154

Error: ENOENT: no such file or directory, scandir '/tmp/xfs-f4bc4a3d/.yarn/unplugged'

How did you fix it?

Wait for the unplugging to complete before calling finalizeInstallWithPnp

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit c45d9b9 into master Mar 29, 2022
@arcanis arcanis deleted the merceyz/fix/pnp-race-condition branch March 29, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants