fix(nm): takes into account scoped packages during syncing tree with disk #4266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larixer
force-pushed
the
larixer/disk-sync-scoped
branch
from
86f0a47
to
063cc7b
Compare
merceyz
requested changes
Mar 25, 2022
packages/acceptance-tests/pkg-tests-specs/sources/node-modules.test.ts
Outdated
Show resolved
Hide resolved
….test.ts Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
merceyz
approved these changes
Mar 25, 2022
merceyz
added a commit
that referenced
this pull request
May 12, 2022
…disk (#4266) * Takes into account scoped packages during syncing tree with disk * Update packages/acceptance-tests/pkg-tests-specs/sources/node-modules.test.ts Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
This is a follow-up PR to #3467. @merceyz noticed the performance regression, this was due to the #3467 didn't take into account scoped packages during syncing tree with disk and it resulted in the reinstallation of all the scoped packages each time.
How did you fix it?
Added handling scoped packages during syncing tree representation with disk contents and added an integration test.
Checklist