fix(nm): apply hoisting algorithm on aliased dependencies #4237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
previously approved these changes
Mar 17, 2022
larixer
changed the title
That's what I wanted to do, but unfortunately, it seems very difficult. I suspect that quite a large dependency tree is needed to showcase the necessity of this condition's presence. I can observe that this condition is needed on one of my large projects, but not all the projects need it. |
merceyz
pushed a commit
that referenced
this pull request
May 12, 2022
* Apply hoisting algorithm on aliased dependencies * Adds a unit test to check hoisting of the aliased packages * Updates conditions to detect hoisting loops to account for aliases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The nm linker did not run a hoisting algorithm inside aliased packages.
Fixes: #4236
How did you fix it?
I have updated conditions inside nm hoister, so that it applied hoisting algorithm inside aliased packages.
In this PR I have also removed
hoisted form:output inNM_DEBUG_LEVEL=2since it pollutes the output and it doesn't help in any way with hoisting troubleshooting.Checklist