-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(essentials): add preferReuse
setting
#4221
Conversation
preferReuse
setting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, I really appreciate that you included a test and updated the JSON schema.
I have a few comments but otherwise this looks good.
packages/acceptance-tests/pkg-tests-specs/sources/commands/add.test.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll hold off on merging until @arcanis has had a chance to look at it as well since you two discussed this on Discord.
LGTM! Thanks @marionebl! |
* feat: expose preferReuse and preferCached * chore: add release data * remove preferCached * remove preferCached from config * set all release strategies * add default * add test * remove unused * docs: improve explanation Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * style: inline type predicate Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * refactor: remove unused Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * fix: move preferReuse config * refactor: use makeTemporaryEnv config creator * fix: remove unused * docs: improve explanation Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> * fix: escape ` Co-authored-by: Kristoffer K. <merceyz@users.noreply.github.com> (cherry picked from commit 5681a5f)
What's the problem this PR addresses?
I want to keep dependencies across all workspaces in sync as much as possible; working with a larger number of collaborators often means
preferInteractive
is not enough to reuse existing versions.--cached
fits the bill but there is no option to enable it by default.E.g. for a scenario where
react@16
is present somewhere in the project I want to installreact@16
overreact@17
given the command...
How did you fix it?
preferReuse
options...
Checklist