Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nm): Support portals to external interdependent workspaces #4207

Merged
merged 1 commit into from
Mar 15, 2022

Conversation

larixer
Copy link
Member

@larixer larixer commented Mar 10, 2022

What's the problem this PR addresses?

Currently, nm installs that try to use portals to external interdependent workspaces fail, because nm linker tries to create self-reference symlinks in the target portal, however, these symlinks SHOULD NOT be created in this case, because --preserve-symlinks option must be used with Node to launch the project and self-references are supported automatically.

Fixes: #4179

How did you fix it?

The nm linker now skips self-reference symlinks creation attempts for external portals.

Checklist

  • I have set the packages that need to be released for my changes to be effective.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@arcanis arcanis merged commit 436dd3b into master Mar 15, 2022
@arcanis arcanis deleted the larixer/nm-external-workspaces-portals branch March 15, 2022 13:49
@lehni
Copy link

lehni commented Mar 20, 2022

thank you @larixer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug?]: yarn link failing with NodeModulesLinker with interdependent workspaces
3 participants