fix(nm): Support portals to external interdependent workspaces #4207
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Currently, nm installs that try to use portals to external interdependent workspaces fail, because nm linker tries to create self-reference symlinks in the target portal, however, these symlinks SHOULD NOT be created in this case, because
--preserve-symlinks
option must be used with Node to launch the project and self-references are supported automatically.Fixes: #4179
How did you fix it?
The nm linker now skips self-reference symlinks creation attempts for external portals.
Checklist