-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pack): support publishConfig.type
#4204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the right field is types
(or typings
, but better only support one), not type
🤔
@arcanis |
Of course, my bad 🤦♀️ |
publishConfig.type
Sorry for the delay @cometkim 🙏 |
* feat: support publishConfig.type * add version file * add more assertions for publishConfig test * fix lint * fix test * Update manifest.json * fix description * chore: mark cli for release Co-authored-by: Maël Nison <nison.mael@gmail.com> Co-authored-by: merceyz <merceyz@users.noreply.github.com>
What's the problem this PR addresses?
This PR allows overriding the
"type"
field on the manifest when packing a package.I wanna build an ESM-first package, but at the same time, I still wanna implicitly load packages with legacy Node resolution in my dev environment to interop with TypeScript which don't yet fully support Node ESM resolution
...
How did you fix it?
by supporting overriding
"type"
with"publishConfig"
object...
Checklist