-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move and document getNpmAuthenticationHeader #3888
refactor: move and document getNpmAuthenticationHeader #3888
Conversation
`packages/plugin-compat/extra/fsevents/fsevents-*.js`, | ||
overrides: [ | ||
{ | ||
files: [`!packages/*/sources/{index,Plugin}.ts`], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While the correct value would be ['!packages/*/sources/index.ts', '!packages/yarnpkg-core/sources/Plugin.ts']
, ESLint seems to still match the files if I put both negated patterns, even though the docs state that:
Override blocks can also specify patterns to exclude from matches. If a file matches any of the excluded patterns, the configuration won't apply.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to press send 😅
packages/gatsby/gatsby-plugin-yarn-introspection/gatsby-node.js
Outdated
Show resolved
Hide resolved
* refactor: move and document getNpmAuthenticationHeader * refactor: feedback * chore: versions * revert: revert leftovers
* refactor: move and document getNpmAuthenticationHeader * refactor: feedback * chore: versions * revert: revert leftovers
What's the problem this PR addresses?
The
getNpmAuthenticationHeader
hook was defined inside aHooks.ts
file instead of the index. Because of this, the hook extraction script didn't see that it wasn't documented.How did you fix it?
Moved it to
index.ts
and added more checks to make sure that this can never happen again.Checklist