fix: handle paths containing spaces #3232
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
previously approved these changes
Aug 5, 2021
merceyz
reviewed
Aug 5, 2021
|
|
||
| if (xfs.existsSync(pnpPath)) { | ||
| let nodeOptions = env.NODE_OPTIONS || ``; | ||
|
|
||
| // We still support .pnp.js files to improve multi-project compatibility. | ||
| // TODO: Drop the question mark in the RegExp after .pnp.js files stop being used. | ||
| const pnpRegularExpression = /\s*--require\s+\S*\.pnp\.c?js\s*/g; | ||
| const pnpRegularExpression = /\s*--require\s+"?.*\.pnp\.c?js"?\s*/g; |
There was a problem hiding this comment.
This deletes everything between the first and last --require flag
--require "C:/foo/.pnp.cjs" --foo="true" --require foo.bar.pnp.cjs
Seems neither of them handle a path with a space in it as well
merceyz
changed the title
--require arguments
Merged
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
@yarnpkg/plugin-pnp'ssetupScriptEnvironmentwas doing an unnecessary Node version check--requirearguments in ourboot-cli-devs / tests / docs were missing double quotes@yarnpkg/plugin-pnp'ssetupScriptEnvironmentwas doing aquotePathIfNeededwhich isn't consistent with the way pnpify does it (always adding double quotes)pnpRegularExpressionwas broken with double-quoted paths or paths that include whitespaceHow did you fix it?
Checklist