Speedup fetch step by limiting concurrency on network requests only #1182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We still need some concurrency on fetch, cf: |
|
Yes... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
The fetch step can be speedup. Currently we are capping number of concurrently running fetchers. The problem with this approach is that we really want to cap network requests, but fetchers do more than that and directly capping fetchers suboptimal and produces download stalls.
How did you fix it?
I am not capping fetchers, but instead cap the network requests directly, this results in 15% speed increase on my laptop of the fetch step (relative to
dns-cachebranch which has limit of 8 concurrent fetcher instead of 5 in master now).