Pin Cython build constraint to < 3.0 #702

nitzmahone · 2023-03-03T23:24:35Z

Temporary workaround for #601.

This is just a stopgap measure to ensure the libyaml extension build continues to function whenever Cython 3.0 is released (date TBD). We'll want to prioritize the extension build rewrite to ensure that PyYAML can support Python > 3.11, as I'd be amazed if they backport things to the Cython 0.x branch once 3.0 has released.

We should discuss if we want to just release this as 6.0.post1 or what, since there are no code changes to the actual library, just build/packaging metadata...

keith · 2023-07-17T17:15:02Z

Merging and releasing this would fix #601

rahul-theorem · 2023-07-17T18:23:21Z

Would it be possible to backport this fix to 5.x & release a hotfix as well? We're currently blocked on upgrading to pyyaml v6 (which we're hoping to resolve this week), but it'd be helpful for a few reasons to be able to pick this up in 5.4.2

hssyoo · 2023-07-17T18:35:09Z

Hi @nitzmahone, the AWS CLI is also currently impacted by this (aws/aws-cli#8036). If we can get this PR merged and released as 6.0.1, it will resolve the issues faced by the AWS CLI and other impacted packages.

DeanWay · 2023-07-17T19:51:23Z

This is just a stopgap measure to ensure the libyaml extension build continues to function whenever Cython 3.0 is released (date TBD).

Cython just released 3.0 so everything that has any kind of transitive dependency on PyYAML will now fail to install. This is now a necessary change.

mharding-hpe · 2023-07-17T19:54:58Z

This is causing a number of products in our organization to be unbuildable. Please consider this another plea for a quick merge and release of this now critical PR.

addyess

This is just what we all need from pyyaml

enmatt · 2023-07-17T20:11:52Z

We've also been wrestling with this dependency issue this morning during our builds.

cgoessling

This would be urgently appreciated.

addyess · 2023-07-17T20:31:36Z

@ingydotnet, @xitology, and @perlpunk thanks for your quick review on this

nitzmahone · 2023-07-17T21:31:30Z

Yep, I'll be doing a 6.0.1 release imminently to cover this (grumblesmurf that I somehow missed the Cython 3.0 release was actually happening since they've been in beta for so long).

No commitment to a 5.x backport/release, but if I can easily resurrect all the necessary wheel builds for it, I might consider it.

antoniogomezalvarado · 2023-07-17T21:46:58Z

For anyone that needs a quick fix for this do the following instead of installing PyYAML directly

git clone https://github.com/yaml/pyyaml.git && \
cd pyyaml && \
git checkout release/5.4.1 && \
sed -i.bak 's/Cython/Cython<3.0/g' pyproject.toml && \
python setup.py sdist && \
pip install --pre dist/PyYAML-5.4.1.tar.gz

To fix an installation error caused by pyyaml cython requirement: AttributeError: cython_sources https://github.com/yaml/pyyaml/blob/c42fa3bff1eabdb64763bb1526d9ea1ccb708479/CHANGES#L9 yaml/pyyaml#702

Fixes an issue I am seeing on Fedora 39. For more details about the upstream fix see yaml/pyyaml#702 Signed-off-by: Christian Gmeiner <cgmeiner@igalia.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25878>

Refer: yaml/pyyaml#702

- pyyaml <= 6.0.0 breaks when cython >= 3.0.0 - release 6.0.1 sets a cython build-time constraint - [PR](yaml/pyyaml#702) - fix will not be [backported to 5.4 or lower](yaml/pyyaml#751) - jinja major version constraint added

* Remove install_dependencies from buld.sh call * remove sudo from folly build * Align cpp wf file with cpu wf file * Make yaml statically linked dependency * move cpp binaries to location based on ts.__file__ * Add FAQ to cpp readme * Update readme to expect installed TS * Fix libtorch install on mac * Add cpp build faqs * Remove llama.cpp as submodule and add through fetch_content * Disable metal in llamacpp example * Fix dangling pointer error in cpp worker * Remove kineto from mac build * Add llvm as mac cpp dependencies (req for clang-tidy) * Enable fPIC for llama.cpp example * Add sudo to clang-tidy link creation * Add undefined symbol faq * fix llv typo * Add install from source to cpp_ci * Correct install from source to cpp_ci * bump up pyyaml version to avoid cython 3 issue yaml/pyyaml#702 * Move cpp ci to M1 mac * Run workflow on self hosted runner * Disable mac ci for cpp * Fix workflow syntax * Run on cpp-ci * Remove sudo * Add apt update for act docker * print library_path in print_env_info.py * print end in cpp ci workflow * Run on github runner * Add upterm session to workflow * Move post mortem upterm session before build * Remove first upterm session * ci debugging * Observe disk space * move _build to /mnt on github runner * fix permission denied * use mount instead of ln * Adjust llamacpp api * Reactivate set -e * Remove note on env variable in cpp readme * Fix linting issue in print_env_info.py * Cleanup ci-cpu-cpp.yml * quieten wget * Add build clean section in cpp/readme * Readjust to llama.cpp api

This updates 2 python packages to versions compatible with python3.12, fixing the following errors when running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER`: 1. `pyyaml` 6.0 build error: `AttributeError: cython_sources`, fixed [here](yaml/pyyaml#702) 2. `construct` import error: ``` File "/tmp/pip-install-ifgk4tul/construct_6d60304f85e249759f6c184ea89f1317/construct/core.py", line 3, in <module> import struct, io, binascii, itertools, collections, pickle, sys, os, tempfile, hashlib, importlib, imp ModuleNotFoundError: No module named 'imp' ``` this was fixed [here](construct/construct@91cc0c6), in version `v2.10.57` of `construct`. I'm just updating to latest though. Now running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER` succeeds when the host python is python3.12.

Avoid cython 3 due to yaml/pyyaml#702

* Revert "Unpin cypthon (#15246)" This reverts commit 659c3b6. * Pin grpcio Avoid cython 3 due to yaml/pyyaml#702 * Delete asyncpg.txt

This updates 2 python packages to versions compatible with python3.12, fixing the following errors when running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER`: 1. `pyyaml` 6.0 build error: `AttributeError: cython_sources`, fixed [here](yaml/pyyaml#702) 2. `construct` import error: ``` File "/tmp/pip-install-ifgk4tul/construct_6d60304f85e249759f6c184ea89f1317/construct/core.py", line 3, in <module> import struct, io, binascii, itertools, collections, pickle, sys, os, tempfile, hashlib, importlib, imp ModuleNotFoundError: No module named 'imp' ``` this was fixed [here](construct/construct@91cc0c6), in version `v2.10.57` of `construct`. I'm just updating to latest though. Now running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER` succeeds when the host python is python3.12.

This updates 2 python packages to versions compatible with python3.12, fixing the following errors when running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER`: 1. `pyyaml` 6.0 build error: `AttributeError: cython_sources`, fixed [here](yaml/pyyaml#702) 2. `construct` import error: ``` File "/tmp/pip-install-ifgk4tul/construct_6d60304f85e249759f6c184ea89f1317/construct/core.py", line 3, in <module> import struct, io, binascii, itertools, collections, pickle, sys, os, tempfile, hashlib, importlib, imp ModuleNotFoundError: No module named 'imp' ``` this was fixed [here](construct/construct@91cc0c6), in version `v2.10.57` of `construct`. I'm just updating to latest though. Now running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER` succeeds when the host python is python3.12. Co-authored-by: Noah Pendleton <2538614+noahp@users.noreply.github.com>

This updates 2 python packages to versions compatible with python3.12, fixing the following errors when running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER`: 1. `pyyaml` 6.0 build error: `AttributeError: cython_sources`, fixed [here](yaml/pyyaml#702) 2. `construct` import error: ``` File "/tmp/pip-install-ifgk4tul/construct_6d60304f85e249759f6c184ea89f1317/construct/core.py", line 3, in <module> import struct, io, binascii, itertools, collections, pickle, sys, os, tempfile, hashlib, importlib, imp ModuleNotFoundError: No module named 'imp' ``` this was fixed [here](construct/construct@91cc0c6), in version `v2.10.57` of `construct`. I'm just updating to latest though. Now running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER` succeeds when the host python is python3.12.

This updates 2 python packages to versions compatible with python3.12, fixing the following errors when running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER`: 1. `pyyaml` 6.0 build error: `AttributeError: cython_sources`, fixed [here](yaml/pyyaml#702) 2. `construct` import error: ``` File "/tmp/pip-install-ifgk4tul/construct_6d60304f85e249759f6c184ea89f1317/construct/core.py", line 3, in <module> import struct, io, binascii, itertools, collections, pickle, sys, os, tempfile, hashlib, importlib, imp ModuleNotFoundError: No module named 'imp' ``` this was fixed [here](construct/construct@91cc0c6), in version `v2.10.57` of `construct`. I'm just updating to latest though. Now running `./scripts/examples/gn_build_example.sh examples/chip-tool BUILDFOLDER` succeeds when the host python is python3.12. Co-authored-by: Noah Pendleton <2538614+noahp@users.noreply.github.com>

* Revert "Unpin cypthon (ansible#15246)" This reverts commit 659c3b6. * Pin grpcio Avoid cython 3 due to yaml/pyyaml#702 * Delete asyncpg.txt

nitzmahone changed the base branch from release/6.0 to master March 3, 2023 23:27

nitzmahone mentioned this pull request Mar 16, 2023

"AttributeError: cython_sources" with Cython 3.0.0a10 #601

Open

mcdonnnj mentioned this pull request Jul 17, 2023

Build error with setuptools 0.68.0 #723

Closed

kyleknap mentioned this pull request Jul 17, 2023

Add support for PyYAML 6.0 aws/aws-cli#8037

Merged

GoelJatin approved these changes Jul 17, 2023

View reviewed changes

rmorshea mentioned this pull request Jul 17, 2023

Restrict Cython to <3 for now pyFFTW/pyFFTW#359

Closed

mharding-hpe approved these changes Jul 17, 2023

View reviewed changes

addyess approved these changes Jul 17, 2023

View reviewed changes

cgoessling approved these changes Jul 17, 2023

View reviewed changes

lalanametala approved these changes Jul 17, 2023

View reviewed changes

romga approved these changes Jul 17, 2023

View reviewed changes

scottwthompson approved these changes Jul 17, 2023

View reviewed changes

jgigliotti approved these changes Jul 17, 2023

View reviewed changes

shmsr mentioned this pull request Jul 17, 2023

Pin PyYAML version to 5.3.1 to avoid CI errors temporarily elastic/beats#36091

Merged

6 tasks

mharding-hpe mentioned this pull request Jul 17, 2023

CASMCMS-8713: Temporarily modify PyYAML, kubernetes install procedure Cray-HPE/cray-product-catalog#263

Merged

ruhul-opcity approved these changes Jul 17, 2023

View reviewed changes

galgertz mentioned this pull request Jul 17, 2023

Error installing Pyyaml==5.4, Cython_sources #724

Closed

ghislainbourgeois approved these changes Jul 17, 2023

View reviewed changes

maxhniebergall mentioned this pull request Jul 17, 2023

Installing Rally develop mode blocked by transitive dependency elastic/rally#1751

Closed

mharding-hpe mentioned this pull request Jul 17, 2023

CASMCMS-8713: Temporarily modify PyYAML install procedure in Dockerfile Cray-HPE/cf-gitea-import#89

Merged

rwblokzijl approved these changes Jul 17, 2023

View reviewed changes

amercader mentioned this pull request Oct 17, 2023

[2.10] Bump pyyaml to 6.0.1 ckan/ckan#7864

Merged

dhruvmanila mentioned this pull request Nov 3, 2023

Upgrade PyYAML to 6.0.1 to avoid build error astral-sh/ruff#8460

Merged

dhruvmanila added a commit to astral-sh/ruff that referenced this pull request Nov 3, 2023

Upgrade PyYAML to 6.0.1 to avoid build error (#8460)

a08c5b7

Refer: yaml/pyyaml#702

Jack-Dane mentioned this pull request Nov 7, 2023

[BUG] "pip install docker-compose" fails on debian 12 docker/compose#11168

Closed

mreso added a commit to pytorch/serve that referenced this pull request Feb 27, 2024

bump up pyyaml version to avoid cython 3 issue yaml/pyyaml#702

ef62412

mcmanustfj mentioned this pull request Mar 26, 2024

PyYAML version 6 can't build, upgrade to 6.0.1 deepdoctection/deepdoctection#304

Closed

licquia mentioned this pull request Apr 5, 2024

CI is failing spdx/spdx-spec#867

Closed

rpatureau mentioned this pull request Apr 19, 2024

Compatibility with newer Python versions lbl-srg/BuildingsPy#547

Merged

noahp mentioned this pull request Apr 30, 2024

Support building chip-tool with python3.12 project-chip/connectedhomeip#33242

Merged

TheRealHaoLiu added a commit to TheRealHaoLiu/awx that referenced this pull request Jun 3, 2024

Pin grpcio

f7c548f

Avoid cython 3 due to yaml/pyyaml#702

TheRealHaoLiu added a commit to ansible/awx that referenced this pull request Jun 3, 2024

Repin cython due to yaml/pyyaml#702 (#15248)

cf09a42

* Revert "Unpin cypthon (#15246)" This reverts commit 659c3b6. * Pin grpcio Avoid cython 3 due to yaml/pyyaml#702 * Delete asyncpg.txt

This was referenced Jun 21, 2024

Notes on kickstarting the RISC-V software layer EESSI/software-layer#552

Open

use PyYAML 6.0.1 instead of 6.0 for recent ReFrame versions to fix problem with Cython 3.x easybuilders/easybuild-easyconfigs#20879

Merged

agners mentioned this pull request Jul 13, 2024

[1.3 cherry-pick] Support building chip-tool with python3.12 project-chip/connectedhomeip#34323

Merged

djyasin pushed a commit to djyasin/awx that referenced this pull request Sep 16, 2024

Repin cython due to yaml/pyyaml#702 (ansible#15248)

b521dd1

* Revert "Unpin cypthon (ansible#15246)" This reverts commit 659c3b6. * Pin grpcio Avoid cython 3 due to yaml/pyyaml#702 * Delete asyncpg.txt

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pin Cython build constraint to < 3.0 #702

Pin Cython build constraint to < 3.0 #702

nitzmahone commented Mar 3, 2023 •

edited

Loading

keith commented Jul 17, 2023

rahul-theorem commented Jul 17, 2023

hssyoo commented Jul 17, 2023

DeanWay commented Jul 17, 2023 •

edited

Loading

mharding-hpe commented Jul 17, 2023

addyess left a comment

enmatt commented Jul 17, 2023

cgoessling left a comment

addyess commented Jul 17, 2023

nitzmahone commented Jul 17, 2023

antoniogomezalvarado commented Jul 17, 2023 •

edited

Loading

Pin Cython build constraint to < 3.0 #702

Pin Cython build constraint to < 3.0 #702

Conversation

nitzmahone commented Mar 3, 2023 • edited Loading

keith commented Jul 17, 2023

rahul-theorem commented Jul 17, 2023

hssyoo commented Jul 17, 2023

DeanWay commented Jul 17, 2023 • edited Loading

mharding-hpe commented Jul 17, 2023

addyess left a comment

Choose a reason for hiding this comment

enmatt commented Jul 17, 2023

cgoessling left a comment

Choose a reason for hiding this comment

addyess commented Jul 17, 2023

nitzmahone commented Jul 17, 2023

antoniogomezalvarado commented Jul 17, 2023 • edited Loading

nitzmahone commented Mar 3, 2023 •

edited

Loading

DeanWay commented Jul 17, 2023 •

edited

Loading

antoniogomezalvarado commented Jul 17, 2023 •

edited

Loading