Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add case sensitivity for command search and improve suggestion rendering #36

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

M1n-74316D65
Copy link

@M1n-74316D65 M1n-74316D65 commented Sep 6, 2024

I made this for me, so why not do a PR :)

  • Added a case sensitivity config for commands
  • Improved the suggestion when adding a /

@M1n-74316D65 M1n-74316D65 changed the title feat: ✨ add case sensitivity for command search and improve suggestion rendering feat: add case sensitivity for command search and improve suggestion rendering Sep 6, 2024
@M1n-74316D65 M1n-74316D65 marked this pull request as draft September 6, 2024 22:45
@M1n-74316D65 M1n-74316D65 marked this pull request as ready for review September 6, 2024 23:37
@xvvvyz
Copy link
Owner

xvvvyz commented Sep 20, 2024

Hi @M1n-74316D65, thanks for the PR! I am not sure I understand the purpose of case insensitive commands. If it's just a stylistic thing so the grid has uppercase keys you could text-transform on .key with CSS. As for the improved suggestions, how are they improved? A screenshot or description would be helpful (:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants