Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ZipArchiveFileSystem and project warnings #88

Merged
merged 4 commits into from
Jun 1, 2024

Conversation

GerardSmit
Copy link
Contributor

Fixes #79
Fixes #81

This PR fixes all the warnings in the Zio project. While doing so, I got motivated to fix up the ZipArchive... 😅

Before _entries was only used for case insensitive paths, now it's always filled with the key as UPath so we always know it's /. This fixed #79. For this to work I created UPathComparer with OrdinalIgnoreCase for case insensitive paths.

I've also created a method called ZipArchiveFileSystem.Save(). The only way to save the ZIP archive is to dispose the ZIP archive, so it closes and re-opens the ZIP archive when possible. This is the only way I can find how we can resolve this.

I've created a ZIP-file in Windows and Linux (WSL2) to validate if the ZipArchiveFileSystem can read both.

@xoofx xoofx merged commit 16d85e5 into xoofx:main Jun 1, 2024
2 checks passed
@xoofx
Copy link
Owner

xoofx commented Jun 1, 2024

Thanks!

@Banane9
Copy link

Banane9 commented Jun 1, 2024

Nice, when that's released I can hopefully get rid of the funny construct to use the netstandard version instead of net4.5 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to save FileSystem changes to disk? ZipArchiveFS DirectoryExists doesn't work as expected
3 participants