Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for copy and save log feature #2079

Merged
merged 2 commits into from
Dec 23, 2020
Merged

Add tests for copy and save log feature #2079

merged 2 commits into from
Dec 23, 2020

Conversation

brusherru
Copy link
Contributor

It relates to #2076 and my previous PR #2078

@brusherru brusherru self-assigned this Dec 22, 2020
nkrkv
nkrkv approved these changes Dec 23, 2020
View reviewed changes
Copy link
Member

@nkrkv nkrkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

evgenykochetkov
evgenykochetkov approved these changes Dec 23, 2020
View reviewed changes
Copy link
Contributor

@evgenykochetkov evgenykochetkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brusherru brusherru merged commit 2cc5c37 into master Dec 23, 2020
@brusherru brusherru deleted the test-copy-save-log branch December 23, 2020 15:48
@evgenykochetkov evgenykochetkov mentioned this pull request Jan 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrkv nkrkv nkrkv approved these changes

@evgenykochetkov evgenykochetkov evgenykochetkov approved these changes

Assignees

@brusherru brusherru

Labels
s:client t:chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brusherru @nkrkv @evgenykochetkov