Feat records #209
Merged
Feat records #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrkv
requested changes
Oct 20, 2020
brusherru
force-pushed
the
feat-records
branch
from
6353e36
to
6a2a634
Compare
|
Within the last fixup commit, I've added a paragraph in the C++ section about unlabeled terminals. |
nkrkv
requested changes
Oct 21, 2020
brusherru
force-pushed
the
feat-records
branch
from
17d22b9
to
6e4a94d
Compare
nkrkv
approved these changes
Oct 26, 2020
docs/guide/records/README.md
Outdated
| } | ||
|
|
||
| void evaluate(Context ctx) { | ||
| Type record = getValue<output_OUT>(ctx); |
There was a problem hiding this comment.
IIRC, it was optimised to just Type record;
brusherru
force-pushed
the
feat-records
branch
from
6e4a94d
to
edba18d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guide for the new records feature ( xodio/xod#2051 ).