Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and add test case for 4:2:2 fuzzing failure #2537

Merged
merged 1 commit into from
Sep 12, 2020
Merged

Fix and add test case for 4:2:2 fuzzing failure #2537

merged 1 commit into from
Sep 12, 2020

Conversation

barrbrain
Copy link
Collaborator 

running 1 test
Overrun in OBU bit buffer into next OBU
test test_encode_decode::fuzz_422_77x17_tile_cols_2_dav1d ... FAILED

failures:

---- test_encode_decode::fuzz_422_77x17_tile_cols_2_dav1d stdout ----
thread 'test_encode_decode::fuzz_422_77x17_tile_cols_2_dav1d' panicked at 'assertion failed: `(left == right)`

Diff < left / right > :
<1
>0

', src/test_encode_decode/mod.rs:144:7

@coveralls
Copy link
Collaborator

coveralls commented Sep 11, 2020 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 80.281% when pulling 92074b3 on barrbrain:fuzz-fail into 62c2066 on xiph:master.

@barrbrain barrbrain force-pushed the fuzz-fail branch 2 times, most recently from f4b43cc to 0b9383c Compare September 11, 2020 20:36
@barrbrain barrbrain changed the title Add test case for 4:2:2 fuzzing failure Fix and add test case for 4:2:2 fuzzing failure Sep 11, 2020
@barrbrain barrbrain marked this pull request as ready for review September 11, 2020 20:40
lu-zero
lu-zero approved these changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you :)

@barrbrain barrbrain force-pushed the fuzz-fail branch 2 times, most recently from 4478d3b to a25c630 Compare September 12, 2020 14:50
@barrbrain
tiling: Determine tile_cols_log2 from selected column count
92074b3 
The column width is adjusted for 4:2:2 content, which in certain
cases results in an actual column count that could be represented
by uniform tiling.
barrbrain
barrbrain commented Sep 12, 2020
View reviewed changes
Copy link
Collaborator Author

@barrbrain barrbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[00:35] <derf> Yeah, I mean, I am okay with this patch landing as-is.

@barrbrain barrbrain merged commit 92074b3 into xiph:master Sep 12, 2020
@barrbrain barrbrain deleted the fuzz-fail branch September 12, 2020 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barrbrain @coveralls @lu-zero