Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Ability to specify delivery status notification #87

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

Herz3h
Copy link
Contributor

@Herz3h Herz3h commented Aug 3, 2023

for issue #86

@xhit
Copy link
Owner

xhit commented Aug 3, 2023

Hi @Herz3h

Thanks for the PR.

I see some code that will broke current implementations here, and I want more simple implementation from dev, I will make changes here, I will let you know for test

Thanks.

@xhit
Copy link
Owner

xhit commented Aug 3, 2023

Done, please test and let me know, I update the readme in the change, use it as reference.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2023

Codecov Report

Merging #87 (7205796) into master (47471be) will decrease coverage by 1.18%.
The diff coverage is 22.91%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   53.81%   52.63%   -1.18%     
==========================================
  Files           7        7              
  Lines        1245     1290      +45     
==========================================
+ Hits          670      679       +9     
- Misses        508      542      +34     
- Partials       67       69       +2     
Flag Coverage Δ
unittests 52.63% <22.91%> (-1.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
email.go 33.17% <19.56%> (-1.00%) ⬇️
smtp.go 77.72% <100.00%> (ø)

@Herz3h
Copy link
Contributor Author

Herz3h commented Aug 4, 2023

Nice refactor !

I have tried it, it's working as expected 👍

@xhit xhit merged commit b1fb802 into xhit:master Aug 4, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants