Auto detect authentication type #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utkarshmani1997
force-pushed
the
auto-detect-auth-type
branch
from
1785868
to
e998e7a
Compare
|
@xhit could you please review? |
|
Hi, thanks for the contribution! This is a breaking change, so, I cannot merge this on master now, can be used in v3 branch, but I prefer another implementation: to add another If With this, current implementation will be available. |
Signed-off-by: utkarshm <utkarshm@jfrog.com>
utkarshmani1997
force-pushed
the
auto-detect-auth-type
branch
from
e998e7a
to
1829554
Compare
|
Sounds good. I have addressed your concerns in the new commit. |
|
@xhit could you please review ? |
|
Hi, I expect review this today Thanks |
|
Merged, thanks for contribution! |
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.