Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarding duplicate email address and setting error #70

Closed
aayush-sib opened this issue Nov 6, 2022 · 4 comments
Closed

Discarding duplicate email address and setting error #70

aayush-sib opened this issue Nov 6, 2022 · 4 comments
Labels
enhancement New feature or request

Comments

@aayush-sib
Copy link

Hi
Thanks for creating this package, great work 👍

I wanted to know if is there any specific reason why you are not adding a duplicate email address in recipients and setting error on email also?

email.recipients, err = addAddress(email.recipients, address.Address)
	if err != nil {
		email.Error = errors.New("Mail Error: " + err.Error() + "; Header: [" + header + "] Address: [" + addresses[i] + "]")
		return email
@xhit
Copy link
Owner

xhit commented Nov 8, 2022

Hi

Internal requirement, maybe export a new variable to disable the check to be used for developers will provide what do you need without to do a breaking change.

@aayush-sib
Copy link
Author

aayush-sib commented Nov 8, 2022

Yes, that will be of great help if something like this can be added. Can you please release a tag with that? I need to use it in my project and it is breaking at this point.
If you are busy with some project I can also raise a PR for the same if you can review and take it forward quickly.

@xhit xhit added enhancement New feature or request and removed needs decision labels Nov 9, 2022
@xhit
Copy link
Owner

xhit commented Nov 9, 2022

Perfect! Please make a PR, I have time to review and make the release in Github

mukul-brevo added a commit to mukul-brevo/go-simple-mail that referenced this issue Nov 9, 2022
@mukul-brevo
Copy link
Contributor

Hi @xhit

I have raised PR for above fix, please have a look.

@xhit xhit closed this as completed in 1c63766 Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants