CachedValue and related enhancements to multi-instance support #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTirapani
approved these changes
Aug 28, 2024
grails-app/services/io/xh/hoist/alertbanner/AlertBannerService.groovy
Outdated
Show resolved
Hide resolved
|
Will look with care tomorrow - eager to see it, thanks for setting this up. |
|
Please see proposed updates in #388 |
TomTirapani
reviewed
Aug 30, 2024
+ Minor updates to ctor validations + Doc comment tweaks + Set `@CompileStatic` on AlertBannerService for good measure
|
CR: Tom, ATM, Greg |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to remove the
oldValuein our change handler -- we could bring it back optionally, but it will require giving up on our performance enhancements to avoid serializing "old" versions of our large data sets